G_Admin/BinderBeispielRegler
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Comments on magic numbers & cast restored

Browse Source
This commit is contained in:
Uwe Jakobeit
2026-04-04 22:32:01 +02:00
parent fe49b993b4
commit 628076ead6
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
controller/Controller.h
View File

@@ -9,6 +9,12 @@ Purpose: [Briefly describe the file's functionality, e.g., "Implements a cla
Notes: [Any relevant details, such as dependencies, usage examples, or known issues.] Notes: [Any relevant details, such as dependencies, usage examples, or known issues.]
*/ */
/*
* todo - 111 Remove magic numbers ( as far as possible ) or make a comment
*/
#pragma once #pragma once
#ifdef BUILD_TARGET_SOM #ifdef BUILD_TARGET_SOM
@@ -228,9 +234,9 @@ void Step(void)
bool Wasserkanister_leer = false; bool Wasserkanister_leer = false;
double Istwert_Temperatur_Verdampferausgang = analogInput.Istwert_Temperatur_Verdampferausgang; double Istwert_Temperatur_Verdampferausgang = analogInput.Istwert_Temperatur_Verdampferausgang;
double Betauungsschutz = 50.0; double Betauungsschutz = 50.0; // 111
double Feuchteband = 10; double Feuchteband = 10; // 111
double Temperaturband = 5; double Temperaturband = 5; // 111
bool reset_flag = binInput.reset_flag; bool reset_flag = binInput.reset_flag;
// --------------------------- // ---------------------------
@@ -703,7 +709,7 @@ void Step(void)
Counter_Status_Uebertemperatur = 0; Counter_Status_Uebertemperatur = 0;
} }
Status_Uebertemperatur = (Counter_Status_Uebertemperatur >= 10 * 4); Status_Uebertemperatur = (Counter_Status_Uebertemperatur >= static_cast<std::uint32_t>(10 * 4));
StatusQuittierung_Uebertemperatur = (Status_Uebertemperatur && Counter_Status_Uebertemperatur < static_cast<std::uint32_t>(11 * 4)) || StatusQuittierung_Uebertemperatur = (Status_Uebertemperatur && Counter_Status_Uebertemperatur < static_cast<std::uint32_t>(11 * 4)) ||
(StatusQuittierung_Uebertemperatur && Sammelalarm_quittiert); (StatusQuittierung_Uebertemperatur && Sammelalarm_quittiert);