From 628076ead6e9e9b049133c9509c7c04e5092c9d7 Mon Sep 17 00:00:00 2001 From: Uwe Jakobeit Date: Sat, 4 Apr 2026 22:32:01 +0200 Subject: [PATCH] Comments on magic numbers & cast restored --- controller/Controller.h | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/controller/Controller.h b/controller/Controller.h index f705ce8..3a44d24 100755 --- a/controller/Controller.h +++ b/controller/Controller.h @@ -9,6 +9,12 @@ Purpose: [Briefly describe the file's functionality, e.g., "Implements a cla Notes: [Any relevant details, such as dependencies, usage examples, or known issues.] */ +/* + * todo - 111 Remove magic numbers ( as far as possible ) or make a comment + */ + + + #pragma once #ifdef BUILD_TARGET_SOM @@ -228,9 +234,9 @@ void Step(void) bool Wasserkanister_leer = false; double Istwert_Temperatur_Verdampferausgang = analogInput.Istwert_Temperatur_Verdampferausgang; - double Betauungsschutz = 50.0; - double Feuchteband = 10; - double Temperaturband = 5; + double Betauungsschutz = 50.0; // 111 + double Feuchteband = 10; // 111 + double Temperaturband = 5; // 111 bool reset_flag = binInput.reset_flag; // --------------------------- @@ -703,7 +709,7 @@ void Step(void) Counter_Status_Uebertemperatur = 0; } - Status_Uebertemperatur = (Counter_Status_Uebertemperatur >= 10 * 4); + Status_Uebertemperatur = (Counter_Status_Uebertemperatur >= static_cast(10 * 4)); StatusQuittierung_Uebertemperatur = (Status_Uebertemperatur && Counter_Status_Uebertemperatur < static_cast(11 * 4)) || (StatusQuittierung_Uebertemperatur && Sammelalarm_quittiert);